Review Request: KBruch - Bug 192707

[Luis Angel Fernandez Fernandez]

> On Sept. 21, 2011, 5:21 p.m., Sebastian Stein wrote:
> > Almost perfect! I just would request to minor changes and you are done:
> > 
> > - don't allow entering "xxxx", so multiple operators in a row
> > - pressing the return key should check the task
> > 
> > Please feel free to directly submit your patch to git trunk after you have incorporated those small changes.
> > 
> > Many thanks for contribution! You closed a long standing bug report!

You're welcome. 

Would you mind to submit the patch? I don't now how exactly I am supposed to do that and besides I've just moved out and everything is quite messy at this moment. I hope everything will be back to normal in a few days.

If you prefer I make the needed changes before you submit the patch it will be fine for me and I'll try to make them as soon as I can.


- Luis Angel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102582/#review6714
-----------------------------------------------------------


On Sept. 19, 2011, 11:18 a.m., Luis Angel Fernandez Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102582/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 11:18 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> This is my first contribution so, please, tell me if I did anything wrong. This patch is intended to solve this bug https://bugs.kde.org/show_bug.cgi?id=192707 in KBruch. After applying this patch (I hope I extracted it rightly) the direct editing is working.
> 
> As I said this is my first submitting so, please, don't hesitate to ask me anything you want/need about this patch.
> 
> 
> This addresses bug 192707.
>     http://bugs.kde.org/show_bug.cgi?id=192707
> 
> 
> Diffs
> -----
> 
>   src/PrimeFactorsLineEdit.h 5e78082 
>   src/PrimeFactorsLineEdit.cpp b71bfba 
>   src/exercisefactorize.h c7d304f 
>   src/exercisefactorize.cpp 48c8874 
> 
> Diff: http://git.reviewboard.kde.org/r/102582/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luis Angel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110922/38d37128/attachment.html>