<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102582/">http://git.reviewboard.kde.org/r/102582/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 21st, 2011, 5:21 p.m., <b>Sebastian Stein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Almost perfect! I just would request to minor changes and you are done:
- don't allow entering "xxxx", so multiple operators in a row
- pressing the return key should check the task
Please feel free to directly submit your patch to git trunk after you have incorporated those small changes.
Many thanks for contribution! You closed a long standing bug report!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're welcome.
Would you mind to submit the patch? I don't now how exactly I am supposed to do that and besides I've just moved out and everything is quite messy at this moment. I hope everything will be back to normal in a few days.
If you prefer I make the needed changes before you submit the patch it will be fine for me and I'll try to make them as soon as I can.</pre>
<br />
<p>- Luis Angel</p>
<br />
<p>On September 19th, 2011, 11:18 a.m., Luis Angel Fernandez Fernandez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Luis Angel Fernandez Fernandez.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2011, 11:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my first contribution so, please, tell me if I did anything wrong. This patch is intended to solve this bug https://bugs.kde.org/show_bug.cgi?id=192707 in KBruch. After applying this patch (I hope I extracted it rightly) the direct editing is working.
As I said this is my first submitting so, please, don't hesitate to ask me anything you want/need about this patch.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=192707">192707</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/PrimeFactorsLineEdit.h <span style="color: grey">(5e78082)</span></li>
<li>src/PrimeFactorsLineEdit.cpp <span style="color: grey">(b71bfba)</span></li>
<li>src/exercisefactorize.h <span style="color: grey">(c7d304f)</span></li>
<li>src/exercisefactorize.cpp <span style="color: grey">(48c8874)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102582/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>