Review Request: KBruch - Bug 192707

[Sebastian Stein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102582/#review6714
-----------------------------------------------------------

Ship it!


Almost perfect! I just would request to minor changes and you are done:

- don't allow entering "xxxx", so multiple operators in a row
- pressing the return key should check the task

Please feel free to directly submit your patch to git trunk after you have incorporated those small changes.

Many thanks for contribution! You closed a long standing bug report!

- Sebastian


On Sept. 19, 2011, 11:18 a.m., Luis Angel Fernandez Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102582/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 11:18 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> This is my first contribution so, please, tell me if I did anything wrong. This patch is intended to solve this bug https://bugs.kde.org/show_bug.cgi?id=192707 in KBruch. After applying this patch (I hope I extracted it rightly) the direct editing is working.
> 
> As I said this is my first submitting so, please, don't hesitate to ask me anything you want/need about this patch.
> 
> 
> This addresses bug 192707.
>     http://bugs.kde.org/show_bug.cgi?id=192707
> 
> 
> Diffs
> -----
> 
>   src/PrimeFactorsLineEdit.h 5e78082 
>   src/PrimeFactorsLineEdit.cpp b71bfba 
>   src/exercisefactorize.h c7d304f 
>   src/exercisefactorize.cpp 48c8874 
> 
> Diff: http://git.reviewboard.kde.org/r/102582/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luis Angel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110921/5b3de020/attachment.html>