Review Request: Implementing a Coordinate Precision Feature in Kig

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102531/#review6274
-----------------------------------------------------------


After having a look at the code, i am not sure if this only affects the viewing of the document since the only thing you are doing is showing more decimals when passing to KLocale::formatNumber? If it is so maybe (just asking you that are the one that uses Kig, i do not even have it installed) it does not make sense adding it to the document itself but to the user local preferences?


misc/kigcoordinateprecisiondialog.cpp
<http://git.reviewboard.kde.org/r/102531/#comment5515>

    I think that using a .ui file instead of creating the layout by hand is the preferred solution nowadays



misc/kigcoordinateprecisiondialog.cpp
<http://git.reviewboard.kde.org/r/102531/#comment5516>

    You are leaking all these widgets, either give them a parent or delete them (i think the layout is reparented on setLayout, so that one is fine).
    
    Also you are missing accelerators & in the checkbox and label (make sure you make the spinbox buddy of the label so the accelarator works)


- Albert


On Sept. 5, 2011, 4:25 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102531/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2011, 4:25 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> Try to address the feature request at bug 262694 by implementing a configuration dialog to specify coordinate precision on the document. This patch does not deal with saving that information to a file.
> 
> 
> This addresses bug 262694.
>     http://bugs.kde.org/show_bug.cgi?id=262694
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b0f7d52 
>   kig/kig_document.h 010c71b 
>   kig/kig_document.cc 33e6dd7 
>   kig/kig_part.h bb9b09e 
>   kig/kig_part.cpp e04f97d 
>   kig/kigpartui.rc a420963 
>   misc/coordinate_system.cpp 251010b 
>   misc/kigcoordinateprecisiondialog.h PRE-CREATION 
>   misc/kigcoordinateprecisiondialog.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102531/diff
> 
> 
> Testing
> -------
> 
> Users can choose between default precision handling and specifying one of their own, so test cases are:
> 1. Start the application, draw a point specifying coordinates
> 2. Right click on the point and change coordindates - note the coordinate precision used in the display of the coordinates
> 3. Go to Settings -> Specify Coordinate Precision... and uncheck the option to use default specification
> 4. Use the spin box to set some coordinate precision, then click Ok
> 5. Right click on the point and change coordindates - the coordinate precision should have changed to whatever was specified in Step 4
> 6. Go to Settings -> Specify Coordinate Precision... again - the Use Default checkbox should be unchecked and the spin box should be set to whatever was specified in Step 4
> 7. Either change precision or use the default, and repeat Steps 4 to 6
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110905/b3487637/attachment.html>