<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102531/">http://git.reviewboard.kde.org/r/102531/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After having a look at the code, i am not sure if this only affects the viewing of the document since the only thing you are doing is showing more decimals when passing to KLocale::formatNumber? If it is so maybe (just asking you that are the one that uses Kig, i do not even have it installed) it does not make sense adding it to the document itself but to the user local preferences?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102531/diff/1/?file=35403#file35403line48" style="color: black; font-weight: bold; text-decoration: underline;">misc/kigcoordinateprecisiondialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KigCoordinatePrecisionDialog::setupUI( bool isUserSpecified, int currentPrecision )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_layout</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QBoxLayout</span><span class="p">(</span> <span class="n">QBoxLayout</span><span class="o">::</span><span class="n">TopToBottom</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that using a .ui file instead of creating the layout by hand is the preferred solution nowadays</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102531/diff/1/?file=35403#file35403line49" style="color: black; font-weight: bold; text-decoration: underline;">misc/kigcoordinateprecisiondialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KigCoordinatePrecisionDialog::setupUI( bool isUserSpecified, int currentPrecision )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_defaultCheckBox</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QCheckBox</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span> <span class="s">"Use default coordinate precision"</span> <span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are leaking all these widgets, either give them a parent or delete them (i think the layout is reparented on setLayout, so that one is fine).
Also you are missing accelerators & in the checkbox and label (make sure you make the spinbox buddy of the label so the accelarator works)</pre>
</div>
<br />
<p>- Albert</p>
<br />
<p>On September 5th, 2011, 4:25 a.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Sept. 5, 2011, 4:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Try to address the feature request at bug 262694 by implementing a configuration dialog to specify coordinate precision on the document. This patch does not deal with saving that information to a file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Users can choose between default precision handling and specifying one of their own, so test cases are:
1. Start the application, draw a point specifying coordinates
2. Right click on the point and change coordindates - note the coordinate precision used in the display of the coordinates
3. Go to Settings -> Specify Coordinate Precision... and uncheck the option to use default specification
4. Use the spin box to set some coordinate precision, then click Ok
5. Right click on the point and change coordindates - the coordinate precision should have changed to whatever was specified in Step 4
6. Go to Settings -> Specify Coordinate Precision... again - the Use Default checkbox should be unchecked and the spin box should be set to whatever was specified in Step 4
7. Either change precision or use the default, and repeat Steps 4 to 6</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=262694">262694</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b0f7d52)</span></li>
<li>kig/kig_document.h <span style="color: grey">(010c71b)</span></li>
<li>kig/kig_document.cc <span style="color: grey">(33e6dd7)</span></li>
<li>kig/kig_part.h <span style="color: grey">(bb9b09e)</span></li>
<li>kig/kig_part.cpp <span style="color: grey">(e04f97d)</span></li>
<li>kig/kigpartui.rc <span style="color: grey">(a420963)</span></li>
<li>misc/coordinate_system.cpp <span style="color: grey">(251010b)</span></li>
<li>misc/kigcoordinateprecisiondialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>misc/kigcoordinateprecisiondialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102531/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>