Review Request: Implementing a Coordinate Precision Feature in Kig

Maurizio Paolini paolini at dmf.unicatt.it
Mon Sep 5 10:47:08 UTC 2011


On Mon, Sep 05, 2011 at 10:35:44AM -0000, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102531/#review6274
> -----------------------------------------------------------
> 
> 
> After having a look at the code, i am not sure if this only affects the viewing of the document since the only thing you are doing is showing more decimals when passing to KLocale::formatNumber? If it is so maybe (just asking you that are the one that uses Kig, i do not even have it installed) it does not make sense adding it to the document itself but to the user local preferences?

Indeed!  It seems actually wrong to save such setting into a kig save file.
I also had a look at the patch, and it looks fine to me.

Maurizio Paolini


More information about the kde-edu mailing list