[kde-edu]: Re: Review Request: KTouch: Fix for "clear history" bug

[Peter Rüthemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6549/
-----------------------------------------------------------

(Updated March 28, 2011, 6:56 p.m.)


Review request for KDE-Edu.


Changes
-------

I needed the time to get deeper into Qt. I hope the fix works now also for you.
The problem was that I cleared the whole hash table.

Good evening
Peter


Summary
-------

In the current version it's not possible to clear the statistics in the "training statistics" window. Only a part of the statistics was cleared.

Changelog:
- The fix clears the current statistics and refreshes the UI
- The sessions restarts at the current level
- The clearStatistics function has now a parameter. The parameter decides whether a new session should be started or not.

This is my first bug fix. Let me know if I violated some coding rules.

Peter


This addresses bug 149758.
    https://bugs.kde.org/show_bug.cgi?id=149758


Diffs (updated)
-----

  /trunk/KDE/kdeedu/ktouch/src/ktouch.cpp 1226325 
  /trunk/KDE/kdeedu/ktouch/src/ktouchstatisticsdialog.cpp 1226325 
  /trunk/KDE/kdeedu/ktouch/src/ktouch.h 1226325 

Diff: http://svn.reviewboard.kde.org/r/6549/diff


Testing
-------

Works with compiled KTouch.


Thanks,

Peter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110328/a2cf9a64/attachment.htm