Review Request: Fix some bugs in parley
Jan Gerrit Marker
jangerrit at weiler-marker.com
Thu Dec 8 20:18:31 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103359/
-----------------------------------------------------------
Review request for KDE Edu.
Description
-------
* Under some circumstances (close Parley when the welcome screen is opened and start it with a file to open (parley <filename>)) the toolbar of the editor mode is not shown. This patch cleans up that code (removes m_hiddenToolbars in ParleyMainwindow as it is not needed) and fixes the visibility of the toolbar.
* Pressing enter in the last line of the vocabulary table does create a new line but does not edit the new line.
* Parley crashes when a new document is opened via "Open Recent" or "Open".
I searched the open Parley bug reports on bugs.kde.org for these issues but I did not find any report.
Diffs
-----
src/editor/editor.cpp 243eb70
src/parleymainwindow.h 48e6d1a
src/parleymainwindow.cpp 4ec0526
src/vocabulary/vocabularyview.cpp 84d91c0
Diff: http://git.reviewboard.kde.org/r/103359/diff/diff
Testing
-------
Fixes all bugs properly for me.
Thanks,
Jan Gerrit Marker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111208/c9b72bf6/attachment.html>
More information about the kde-edu
mailing list