Review Request: Fix some bugs in parley

[Frederik Gladhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103359/#review9366
-----------------------------------------------------------


Please break it up into three commits. You wrote yourself that it fixes independent issues.

Check
http://techbase.kde.org/Policies/Kdelibs_Coding_Style
for coding style. Consistency is really helpful when reading the code :)


src/parleymainwindow.cpp
<http://git.reviewboard.kde.org/r/103359/#comment7725>

    I don't mind too much, but there is no reason to change Q_FOREACH to foreach, is there?



src/parleymainwindow.cpp
<http://git.reviewboard.kde.org/r/103359/#comment7726>

    Parley follows KDE libs coding style.
    {} are mandatory for ifs. Especially when you have an else.
    
    Are you sure you don't have to check for the pointer to be invalid? if (toolbar && toolbar->objectName() ...)


- Frederik Gladhorn


On Dec. 8, 2011, 8:18 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103359/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2011, 8:18 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> * Under some circumstances (close Parley when the welcome screen is opened and start it with a file to open (parley <filename>)) the toolbar of the editor mode is not shown. This patch cleans up that code (removes m_hiddenToolbars in ParleyMainwindow as it is not needed) and fixes the visibility of the toolbar.
> * Pressing enter in the last line of the vocabulary table does create a new line but does not edit the new line.
> * Parley crashes when a new document is opened via "Open Recent" or "Open".
> 
> I searched the open Parley bug reports on bugs.kde.org for these issues but I did not find any report.
> 
> 
> Diffs
> -----
> 
>   src/editor/editor.cpp 243eb70 
>   src/parleymainwindow.h 48e6d1a 
>   src/parleymainwindow.cpp 4ec0526 
>   src/vocabulary/vocabularyview.cpp 84d91c0 
> 
> Diff: http://git.reviewboard.kde.org/r/103359/diff/diff
> 
> 
> Testing
> -------
> 
> Fixes all bugs properly for me.
> 
> 
> Thanks,
> 
> Jan Gerrit Marker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111230/0dd60a42/attachment.html>