Review Request: Finish the declension editing support of parley's UI

Tue Dec 6 21:45:16 UTC 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103331/
-----------------------------------------------------------

(Updated Dec. 6, 2011, 9:45 p.m.)

Review request for KDE Edu.

Changes
-------

Update the screenshot of the button layout.
Add a screenshot of the conjugation widget.

Update the patch according to Frederik's suggestions.

Description
-------

This patch continues the work done by Frederik Gladhorn on declension editing. Depending on review 103325 which extends libkdeedu's support for declensions this patch allows to edit the declensions of nouns and adjectives. As conjugations and declensions are both inflections and a word can only have one of them (as far as I know from Latin, German and English and the German Wikipedia articles) I merged them into one dock, called "Inflection". The geometry of some buttons is not that nice but I'd like to get comments on this first and polish it afterwards.

There's currently no practice mode but I plan to add it in the near future.

Diffs (updated)
-----

  src/editor/editor.h 3362211 
  src/editor/editor.cpp 243eb70 
  src/editor/editorui.rc 28230818 
  src/editor/inflectionwidget.h PRE-CREATION 
  src/editor/inflectionwidget.cpp PRE-CREATION 
  src/editor/declensionwidget.ui 9c31a40 
  src/editor/declensionwidget.h 71e16c7 
  src/editor/declensionwidget.cpp dbe4a05 
  src/editor/conjugationwidget.cpp f3b1702 
  src/editor/conjugationwidget.ui cff5ebf 
  src/CMakeLists.txt d219687 
  src/editor/conjugationwidget.h 11cd937 

Diff: http://git.reviewboard.kde.org/r/103331/diff/diff

Testing
-------

Works for me.

Screenshots (updated)
-----------

Declension: noun
  http://git.reviewboard.kde.org/r/103331/s/351/
Declension: adjective
  http://git.reviewboard.kde.org/r/103331/s/352/
New button layout and new title
  http://git.reviewboard.kde.org/r/103331/s/354/
Conjugation
  http://git.reviewboard.kde.org/r/103331/s/355/

Thanks,

Jan Gerrit Marker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111206/0a5bacdd/attachment.html>