Review Request: Finish the declension editing support of parley's UI

[Jan Gerrit Marker]

> On Dec. 6, 2011, 3:45 p.m., Frederik Gladhorn wrote:
> > Great stuff. I find the button layout in the screenshot confusing. How about adding a spacer below them or something?
> > I was about to comment that I had planned to unify these dock widgets. I wholeheartedly approve of you doing just that.
> > 
> > Inflection is the proper term but people will have trouble sorting out the grammar terms I fear...
> > Maybe the title should be something like "Inflection (verbs/adjectives/nouns)" ??? I wonder if there is a better way to make it obvious.

I added a spacer to the button layout and renamed the "Inflection" title (not the action in the menu as that would be too long) to "Inflection (verbs, adjectives, nouns)" (I think commas are not that technical), the screenshot is updated.

Additionally I noticed that the declension widget is a groupbox and the conjugation widget is not. As a groupbox seems to be better, because you can easily see whether you're editing a conjugation or a declension, I transformed the conjugation widget. A screenshot is added.


> On Dec. 6, 2011, 3:45 p.m., Frederik Gladhorn wrote:
> > src/editor/declensionwidget.cpp, line 157
> > <http://git.reviewboard.kde.org/r/103331/diff/1/?file=42744#file42744line157>
> >
> >     Maybe a better  name is in order here? currentGlobalFlag is very generic.

What about currentAdditionalWordFlag? The new patch contains this method name.


- Jan Gerrit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103331/#review8760
-----------------------------------------------------------


On Dec. 6, 2011, 9:45 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103331/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2011, 9:45 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> This patch continues the work done by Frederik Gladhorn on declension editing. Depending on review 103325 which extends libkdeedu's support for declensions this patch allows to edit the declensions of nouns and adjectives. As conjugations and declensions are both inflections and a word can only have one of them (as far as I know from Latin, German and English and the German Wikipedia articles) I merged them into one dock, called "Inflection". The geometry of some buttons is not that nice but I'd like to get comments on this first and polish it afterwards.
> 
> There's currently no practice mode but I plan to add it in the near future.
> 
> 
> Diffs
> -----
> 
>   src/editor/editor.h 3362211 
>   src/editor/editor.cpp 243eb70 
>   src/editor/editorui.rc 28230818 
>   src/editor/inflectionwidget.h PRE-CREATION 
>   src/editor/inflectionwidget.cpp PRE-CREATION 
>   src/editor/declensionwidget.ui 9c31a40 
>   src/editor/declensionwidget.h 71e16c7 
>   src/editor/declensionwidget.cpp dbe4a05 
>   src/editor/conjugationwidget.cpp f3b1702 
>   src/editor/conjugationwidget.ui cff5ebf 
>   src/CMakeLists.txt d219687 
>   src/editor/conjugationwidget.h 11cd937 
> 
> Diff: http://git.reviewboard.kde.org/r/103331/diff/diff
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Screenshots
> -----------
> 
> Declension: noun
>   http://git.reviewboard.kde.org/r/103331/s/351/
> Declension: adjective
>   http://git.reviewboard.kde.org/r/103331/s/352/
> New button layout and new title
>   http://git.reviewboard.kde.org/r/103331/s/354/
> Conjugation
>   http://git.reviewboard.kde.org/r/103331/s/355/
> 
> 
> Thanks,
> 
> Jan Gerrit Marker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111206/a296289a/attachment-0001.html>