<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103331/">http://git.reviewboard.kde.org/r/103331/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 6th, 2011, 3:45 p.m., <b>Frederik Gladhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great stuff. I find the button layout in the screenshot confusing. How about adding a spacer below them or something?
I was about to comment that I had planned to unify these dock widgets. I wholeheartedly approve of you doing just that.
Inflection is the proper term but people will have trouble sorting out the grammar terms I fear...
Maybe the title should be something like "Inflection (verbs/adjectives/nouns)" ??? I wonder if there is a better way to make it obvious.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I added a spacer to the button layout and renamed the "Inflection" title (not the action in the menu as that would be too long) to "Inflection (verbs, adjectives, nouns)" (I think commas are not that technical), the screenshot is updated.
Additionally I noticed that the declension widget is a groupbox and the conjugation widget is not. As a groupbox seems to be better, because you can easily see whether you're editing a conjugation or a declension, I transformed the conjugation widget. A screenshot is added.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 6th, 2011, 3:45 p.m., <b>Frederik Gladhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103331/diff/1/?file=42744#file42744line157" style="color: black; font-weight: bold; text-decoration: underline;">src/editor/declensionwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DeclensionWidget::slotMakeNoun()</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int DeclensionWidget::currentGlobalFlag()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt"><span class="hl">void</span></span> <span class="n">DeclensionWidget</span><span class="o">::</span><span class="n"><span class="hl">slotMakeNoun</span></span><span class="p">()</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">104</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt"><span class="hl">int</span></span> <span class="n">DeclensionWidget</span><span class="o">::</span><span class="n"><span class="hl">currentGlobalFlag</span></span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe a better name is in order here? currentGlobalFlag is very generic.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about currentAdditionalWordFlag? The new patch contains this method name.</pre>
<br />
<p>- Jan Gerrit</p>
<br />
<p>On December 6th, 2011, 9:45 p.m., Jan Gerrit Marker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jan Gerrit Marker.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2011, 9:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch continues the work done by Frederik Gladhorn on declension editing. Depending on review 103325 which extends libkdeedu's support for declensions this patch allows to edit the declensions of nouns and adjectives. As conjugations and declensions are both inflections and a word can only have one of them (as far as I know from Latin, German and English and the German Wikipedia articles) I merged them into one dock, called "Inflection". The geometry of some buttons is not that nice but I'd like to get comments on this first and polish it afterwards.
There's currently no practice mode but I plan to add it in the near future.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works for me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor/editor.h <span style="color: grey">(3362211)</span></li>
<li>src/editor/editor.cpp <span style="color: grey">(243eb70)</span></li>
<li>src/editor/editorui.rc <span style="color: grey">(28230818)</span></li>
<li>src/editor/inflectionwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/editor/inflectionwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/editor/declensionwidget.ui <span style="color: grey">(9c31a40)</span></li>
<li>src/editor/declensionwidget.h <span style="color: grey">(71e16c7)</span></li>
<li>src/editor/declensionwidget.cpp <span style="color: grey">(dbe4a05)</span></li>
<li>src/editor/conjugationwidget.cpp <span style="color: grey">(f3b1702)</span></li>
<li>src/editor/conjugationwidget.ui <span style="color: grey">(cff5ebf)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(d219687)</span></li>
<li>src/editor/conjugationwidget.h <span style="color: grey">(11cd937)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103331/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103331/s/351/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/04/declension-noun_400x100.png" style="border: 1px black solid;" alt="Declension: noun" /></a>
<a href="http://git.reviewboard.kde.org/r/103331/s/352/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/04/declension-adjective_400x100.png" style="border: 1px black solid;" alt="Declension: adjective" /></a>
<a href="http://git.reviewboard.kde.org/r/103331/s/354/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/06/inflection-buttons_1_400x100.png" style="border: 1px black solid;" alt="New button layout and new title" /></a>
<a href="http://git.reviewboard.kde.org/r/103331/s/355/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/06/conjugation-verb_400x100.png" style="border: 1px black solid;" alt="Conjugation" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>