Crow Translate

[Albert Astals Cid]

El dimarts, 9 de juliol del 2024, a les 0:48:12 (CEST), Hennadii Chernyshchyk 
va escriure:
> > No I mean link to BrezeIcons library.
> 
> Ah, I didn't know that there was a library for it! Will change it, thank
> you.
> 
> > The problem is that the defaultLocale() function returns the C QLocale
> 
> which is wrong since that's not the default locale on my user.
> 
> I never apply QLocale::c(). I see how it could be confusing, but I actually
> use it as a special value to apply a system locale here:
> https://invent.kde.org/office/crow-translate/-/blob/master/src/settings/apps
> ettings.cpp#L63 (I may need to refactor this part)

Fixed in 62e49303157cdfdf2758b09ff7b4530ff1eb921c :)

Possibly related to translations, the sizing could be a bit better, see 
https://i.imgur.com/wvSrGc0.png

Where it says "Traducció auto" it is just "Traducció automàtica" but the text 
is cut. You can see the text if you make the window wider.

This is not critical, but would be nice that a user doesn't get cut text on 
startup. 

> 
> By any chance you run a flatpak? If yes, I know about this issue and I am
> working on it right now:
> https://invent.kde.org/office/crow-translate/-/merge_requests/724.
> For some reason it doesn't work when packaged as flatpak, I am
> investigating it right now.
> 
> > Self hosted by who?
> 
> Can be self-hosted by anyone. Here is the list of known instances:
> https://codeberg.org/aryak/mozhi#instances

But which one are we using?

Or is it a random one each time?

> 
> > How does that matter?
> > If i add the text of my potentially Nobel winning research for
> 
> translation, it
> 
> > will still end up in NonFreeSoftwareService and NonFreeSoftwareService
> 
> can
> 
> > read it and potentially steal it.
> 
> Ah, it's a valid concern.
> What I tried to say is that it doesn't spy on specific users since data
> basically goes through an instance instead of talking to a non-free service
> directly.
> Would you prefer to add a warning on a first startup?


A warning on first startup sounds good to me :) Could I ask for a dialog that 
has a "don't show again" check and the check is not checked?  

Cheers,
  Albert

> 
> вт, 9 июл. 2024 г. в 01:26, Albert Astals Cid <aacid at kde.org>:
> > El dimarts, 9 de juliol del 2024, a les 0:12:48 (CEST), Hennadii
> > Chernyshchyk
> > 
> > va escriure:
> > > Thanks for looking into the app!
> > > 
> > > > Please remove the submodule of breeze-icons and replace it by a
> > > 
> > > dependency to breeze-icons.
> > > 
> > > Could you elaborate? You mean to use something like FetchContent from
> > 
> > CMake?
> > 
> > > I use it to bundle icons for Windows since on Windows there are no icon
> > > themes.
> > 
> > No I mean link to BrezeIcons library.
> > 
> > > > Translations are not loaded properly. (i.e. i get the UI in English
> > > 
> > > instead of
> > > Catalan)
> > > 
> > > Are you running the application from the build directory? If yes, then
> > 
> > you
> > 
> > > won't have translation because the application expects them to be
> > > located
> > > in a system path. I have an application from the latest commit installed
> > > system-wide and translations work.
> > > I can tweak it to make it work from the build directory as well by
> > 
> > looking
> > 
> > > into the ECMPoQm folder.
> > 
> > The problem is that the defaultLocale() function returns the C QLocale
> > which
> > is wrong since that's not the default locale on my user.
> > 
> > > > I would appreciate a big warning when using non-free software engines
> > > 
> > > All engines use Mozhi which is self-hosted.
> > 
> > Self hosted by who?
> > 
> > > Yes, it talks to non-free
> > > software engines, but it's similar to Invidious or Piped - all
> > > communication is done through a user-choosed instance.
> > 
> > How does that matter?
> > 
> > If i add the text of my potentially Nobel winning research for
> > translation, it
> > will still end up in NonFreeSoftwareService and NonFreeSoftwareService can
> > read it and potentially steal it.
> > 
> > Cheers,
> > 
> >   Albert
> >   
> > > I'm fine with adding a warning, but I also think that privacy is
> > > somewhat
> > > protected.
> > > 
> > > вт, 9 июл. 2024 г. в 00:53, Albert Astals Cid <aacid at kde.org>:
> > > > El dissabte, 6 de juliol del 2024, a les 0:57:22 (CEST), Hennadii
> > > > Chernyshchyk
> > > > 
> > > > va escriure:
> > > > > Hi!
> > > > > 
> > > > > I'm one of the developers of Crow Translate
> > > > > <https://invent.kde.org/office/crow-translate>, a translator app
> > 
> > that
> > 
> > > > uses
> > > > 
> > > > > Mozhi <https://codeberg.org/aryak/mozhi>. No, the app can't
> > 
> > translate
> > 
> > > > crow
> > > > 
> > > > > calls - that's just the name :D
> > > > > But you can quickly translate text from selection or from the
> > 
> > screen. We
> > 
> > > > > also provide a CLI app and D-Bus API for translation automation. The
> > 
> > app
> > 
> > > > is
> > > > 
> > > > > written in QtWidgets, but I made it adaptive. On linuxphoneapps.org
> > > > > <https://linuxphoneapps.org/apps/io.crow_translate.crowtranslate/>
> > 
> > it's
> > 
> > > > > rated 5 for mobile fit (I use it on my PinePhone Pro).
> > > > > 
> > > > > Crow Translate has recently been incubated and is now looking to
> > 
> > become
> > 
> > > > an
> > > > 
> > > > > official part of KDE. For this we are now in KDE Review and have
> > 
> > already
> > 
> > > > > worked through the checklist in #699. Please make sure you are fine
> > 
> > with
> > 
> > > > > the current state of Crow Translate being released as a KDE project,
> > > > > because we plan on moving on to making a release soon after the KDE
> > > > 
> > > > review
> > > > 
> > > > > time period has completed.
> > > > 
> > > > Please remove the submodule of breeze-icons and replace it by a
> > 
> > dependency
> > 
> > > > to
> > > > breeze-icons.
> > > > 
> > > > The other submodules would ideally also go away but submoduling our
> > > > own
> > > > things
> > > > is a no go.
> > > > 
> > > > Translations are not loaded properly. (i.e. i get the UI in English
> > > > instead of
> > > > Catalan)
> > > > 
> > > > I would appreciate a big warning when using non-free software engines
> > 
> > that
> > 
> > > > there's no expectation of privacy on what is being translated (and
> > 
> > same on
> > 
> > > > the
> > > > Free Software ones if they don't promise that level of privacy).
> > > > 
> > > > Cheers,
> > > > 
> > > >   Albert