New repo in kdereview: KRecorder

[Nate Graham]

On 11/24/22 16:32, Devin wrote:
>> I can still see this: https://i.imgur.com/MrrwyAo.jpg
> 
> No matter how I try to resize the window, I can't seem to reproduce
> the issue... weird

I can reproduce it in the following way on Desktop:
1. Start with the window in a wide state, in two-pane view
2. Resize it to be narrower, so it moves into one-pane view
3. Without stopping resizing (i.e. don't release your fingers from the 
mouse or touchpad) make the window wider again so it returns to 
two-column view
4. Now make it narrower again


>> I found a new issue: when dragging the window, the view backgrounds become partially transparent  during the drag, as if I had the Translucency KWin effect active--but I do not. In addition, after the window id dropped, its background flickers a bit. None of my other windows do this, and KRecorder didn't do this the last time I did it.
> 
> This is strange, I did add a blur behind the window a month back, but
> it shouldn't be making the window transparent during drag... I don't
> currently experience this

I'm on Wayland with 200% scale using a 10th generation Intel iGPU FWIW.

But... This problem shouldn't be able to happen in the first place 
because the window should have transparency and blur at all. We don't do 
this in any other apps and we shouldn't do it here. If this is a thing 
we want, we should do it in Breeze, or maaaaaaybe in Kirigami for PlaMo 
apps, but definitely not just in this one random app.




I found one new issue that wasn't present the last time I tested: while 
recording, the volume level indicator always indicates that it's 
recording at max volume, even when I'm just, like, whispering:

https://i.imgur.com/FjytzJa.jpg


Nate

> 
>> Maybe when we're in widescreen mode and there are no recordings, the right pane's placeholder message could have no action and simply say "Click the "Record" button to make a new recording". It can probably remove the "Record a new recording" action even when there are any recordings, since the left pane always has a "Record" action in its header.
> 
> Added
> 
> On Mon, Nov 14, 2022 at 7:22 PM Nate Graham <nate at kde.org> wrote:
>>
>> Much better! Most issues are fixed now. I feel like we're close. See a
>> few remaining comments:
>>
>>
>>>> The left pane's placeholder message is off-center with narrow windows.
>>>
>>> Fixed.
>>
>> I can still see this: https://i.imgur.com/MrrwyAo.jpg
>>
>>
>>
>>>> On the recording page, the "stop recording" button is red which is typically our "destructive action" color.
>>>
>>> I've attempted to use other colours, as well as the selection colour,
>>> but they either don't contrast when flat, or don't really seem like
>>> buttons.
>>>
>>> I would argue that this is a destructive action, because it stops the
>>> recording without any way of going back. This colour is also typically
>>> used for stop buttons on other platforms, so I would not say that it
>>> is particularly out of place, in my opinion.
>>
>> When I look at other platforms, what I see is that it's common and
>> traditional for the *record* button to be a red circle, but the stop
>> button is always a black square. And stopping the recording isn't
>> destructive; *deleting* the recording is destructive.
>>
>> Furthermore it's inconsistent with the stop button on the playback view,
>> which is black: https://i.imgur.com/3u1Ogjy.jpg
>>
>>
>>
>>>> Playback buttons can get cut off with short windows:
>>>
>>> Fixed.
>>
>> I can still see this:
>> - https://i.imgur.com/UH9Ik8Z.jpg
>> - https://i.imgur.com/AnTyYyb.jpg
>>
>>
>>
>> I found a new issue: when dragging the window, the view backgrounds
>> become partially transparent  during the drag, as if I had the
>> Translucency KWin effect active--but I do not. In addition, after the
>> window id dropped, its background flickers a bit. None of my other
>> windows do this, and KRecorder didn't do this the last time I did it.
>>
>> https://imgur.com/a/ZT5zJsD
>>
>>
>>
>> I continue to think the two-column view is a bit awkward when there are
>> no recordings, and now it results in two record actions shown at the
>> same time, but with different text: https://i.imgur.com/cupborn.jpg
>>
>> Maybe when we're in widescreen mode and there are no recordings, the
>> right pane's placeholder message could have no action and simply say
>> "Click the "Record" button to make a new recording". It can probably
>> remove the "Record a new recording" action even when there are any
>> recordings, since the left pane always has a "Record" action in its header.
>>
>>
>> Nate