Review Request 127425: Fix kcoreaddons build with threads

Allen Winter winter at kde.org
Sat Mar 19 14:22:39 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127425/
-----------------------------------------------------------

(Updated March 19, 2016, 2:22 p.m.)


Review request for kdelibs.


Changes
-------

removed an extra blank line


Repository: kcoreaddons


Description
-------

CMake 3.0.2 at at least doesn't know what the Threads::Threads library is.


Diffs (updated)
-----

  src/lib/CMakeLists.txt 44f1516 

Diff: https://git.reviewboard.kde.org/r/127425/diff/


Testing
-------

kcoreaddons build ok now.

was getting the CMake warning:
CMake Warning (dev) at src/lib/CMakeLists.txt:99 (add_library):
  Policy CMP0028 is not set: Double colon in target name means ALIAS or
  IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  Target "KF5CoreAddons" links to target "Threads::Threads" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
  
followed by the linker error:
 /usr/bin/ld: cannot find -lThreads::Threads


Thanks,

Allen Winter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160319/d4dd0690/attachment.htm>


More information about the kde-core-devel mailing list