Review Request 127425: Fix kcoreaddons build with threads
Kevin Funk
kfunk at kde.org
Sat Mar 19 19:06:08 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127425/#review93722
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Funk
On March 19, 2016, 2:22 p.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127425/
> -----------------------------------------------------------
>
> (Updated March 19, 2016, 2:22 p.m.)
>
>
> Review request for kdelibs.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> CMake 3.0.2 at at least doesn't know what the Threads::Threads library is.
>
>
> Diffs
> -----
>
> src/lib/CMakeLists.txt 44f1516
>
> Diff: https://git.reviewboard.kde.org/r/127425/diff/
>
>
> Testing
> -------
>
> kcoreaddons build ok now.
>
> was getting the CMake warning:
> CMake Warning (dev) at src/lib/CMakeLists.txt:99 (add_library):
> Policy CMP0028 is not set: Double colon in target name means ALIAS or
> IMPORTED target. Run "cmake --help-policy CMP0028" for policy details.
> Use the cmake_policy command to set the policy and suppress this warning.
>
> Target "KF5CoreAddons" links to target "Threads::Threads" but the target
> was not found. Perhaps a find_package() call is missing for an IMPORTED
> target, or an ALIAS target is missing?
>
> followed by the linker error:
> /usr/bin/ld: cannot find -lThreads::Threads
>
>
> Thanks,
>
> Allen Winter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160319/95337461/attachment.htm>
More information about the kde-core-devel
mailing list