Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Jan 13 00:31:14 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126704/#review90985
-----------------------------------------------------------
src/iconthemesmodel.cpp (line 54)
<https://git.reviewboard.kde.org/r/126704/#comment62152>
No-op change.
src/iconthemesmodel.cpp (line 98)
<https://git.reviewboard.kde.org/r/126704/#comment62153>
Now that you have the CursorsThemeModel that shouldn't be needed anymore.
If it still is, add a virtual.
- Aleix Pol Gonzalez
On Jan. 12, 2016, 4:53 p.m., Andrey Bondrov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126704/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 4:53 p.m.)
>
>
> Review request for kde-workspace, Aleix Pol Gonzalez and Harald Sitter.
>
>
> Repository: kde-gtk-config
>
>
> Description
> -------
>
> Implement changing cursor theme for GTK applications. It's needed to set cursor theme for Firefox and other applications that use GTK configs to set cursors.
>
>
> Diffs
> -----
>
> CMakeLists.txt bf002d1
> src/abstractappearance.h 378b71d
> src/abstractappearance.cpp 6d0dc27
> src/appearancegtk2.cpp b1e0b52
> src/appearancegtk3.cpp 5c481c9
> src/appearencegtk.h f797a08
> src/appearencegtk.cpp 9dee2d5
> src/cursorthemesmodel.h PRE-CREATION
> src/cursorthemesmodel.cpp PRE-CREATION
> src/gtkconfigkcmodule.h 032a5ef
> src/gtkconfigkcmodule.cpp 3d70f6e
> src/iconthemesmodel.cpp 07c7ad7
> src/ui/gui.ui ebfacdf
>
> Diff: https://git.reviewboard.kde.org/r/126704/diff/
>
>
> Testing
> -------
>
> Tested on my local machine. Seems to do what it should properly.
>
>
> Thanks,
>
> Andrey Bondrov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160113/478985b3/attachment.htm>
More information about the kde-core-devel
mailing list