Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

[Andrey Bondrov]

> On Янв. 13, 2016, 12:31 д.п., Aleix Pol Gonzalez wrote:
> > src/iconthemesmodel.cpp, line 99
> > <https://git.reviewboard.kde.org/r/126704/diff/3/?file=430486#file430486line99>
> >
> >     Now that you have the CursorsThemeModel that shouldn't be needed anymore.
> >     
> >     If it still is, add a virtual.

I added "if(!theme.name().isEmpty())" check to IconThemesModel because there can be directories with index.theme file but without any other files.

Like

---------------
$ pwd
/usr/share/icons/default

$ ls
index.theme

$ cat index.theme 
[Icon Theme]
Inherits=wonderland
---------------

Without "if(!theme.name().isEmpty())" we have entries with empty names in the list. But it surely needs better check. Such directories shouldn't be added to availableIcons list at all. So I removed "if(!theme.name().isEmpty())" from this review request.


- Andrey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126704/#review90985
-----------------------------------------------------------


On Янв. 13, 2016, 6:03 д.п., Andrey Bondrov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126704/
> -----------------------------------------------------------
> 
> (Updated Янв. 13, 2016, 6:03 д.п.)
> 
> 
> Review request for kde-workspace, Aleix Pol Gonzalez and Harald Sitter.
> 
> 
> Repository: kde-gtk-config
> 
> 
> Description
> -------
> 
> Implement changing cursor theme for GTK applications. It's needed to set cursor theme for Firefox and other applications that use GTK configs to set cursors.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 78814fc 
>   src/abstractappearance.h 378b71d 
>   src/abstractappearance.cpp 6d0dc27 
>   src/appearancegtk2.cpp b1e0b52 
>   src/appearancegtk3.cpp 5c481c9 
>   src/appearencegtk.h f797a08 
>   src/appearencegtk.cpp 9dee2d5 
>   src/cursorthemesmodel.h PRE-CREATION 
>   src/cursorthemesmodel.cpp PRE-CREATION 
>   src/gtkconfigkcmodule.h 032a5ef 
>   src/gtkconfigkcmodule.cpp 3d70f6e 
>   src/ui/gui.ui ebfacdf 
> 
> Diff: https://git.reviewboard.kde.org/r/126704/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local machine. Seems to do what it should properly.
> 
> 
> Thanks,
> 
> Andrey Bondrov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160113/30b4e3b2/attachment.htm>