<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126704/">https://git.reviewboard.kde.org/r/126704/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126704/diff/3/?file=430486#file430486line54" style="color: black; font-weight: bold; text-decoration: underline;">src/iconthemesmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QList<QDir> IconThemesModel::installedThemesPaths()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="n">dir</span><span class="p">.</span><span class="n">exists</span><span class="p">()</span> <span class="o">&&</span> <span class="o">!</span><span class="n">dir</span><span class="p">.</span><span class="n">exists</span><span class="p">(</span><span class="s">"cursors"</span><span class="p">)</span> <span class="o">&&</span> <span class="n">dir</span><span class="p">.</span><span class="n">exists</span><span class="p">(</span><span class="s">"index.theme"</span><span class="p">))</span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="n">dir</span><span class="p">.</span><span class="n">exists</span><span class="p">()</span> <span class="o">&&</span> <span class="o">!</span><span class="n">dir</span><span class="p">.</span><span class="n">exists</span><span class="p">(</span><span class="s">"cursors"</span><span class="p">)</span> <span class="o">&&</span> <span class="n">dir</span><span class="p">.</span><span class="n">exists</span><span class="p">(</span><span class="s">"index.theme"</span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No-op change.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126704/diff/3/?file=430486#file430486line99" style="color: black; font-weight: bold; text-decoration: underline;">src/iconthemesmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString IconThemesModel::findFilesRecursively(const QStringList& wildcard, const QDir& directory)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">99</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">98</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="o">!</span><span class="n">theme</span><span class="p">.</span><span class="n">name</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">())</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now that you have the CursorsThemeModel that shouldn't be needed anymore.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If it still is, add a virtual.</p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On January 12th, 2016, 4:53 p.m. CET, Andrey Bondrov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kde-workspace, Aleix Pol Gonzalez and Harald Sitter.</div>
<div>By Andrey Bondrov.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2016, 4:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-gtk-config
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implement changing cursor theme for GTK applications. It's needed to set cursor theme for Firefox and other applications that use GTK configs to set cursors.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on my local machine. Seems to do what it should properly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(bf002d1)</span></li>
<li>src/abstractappearance.h <span style="color: grey">(378b71d)</span></li>
<li>src/abstractappearance.cpp <span style="color: grey">(6d0dc27)</span></li>
<li>src/appearancegtk2.cpp <span style="color: grey">(b1e0b52)</span></li>
<li>src/appearancegtk3.cpp <span style="color: grey">(5c481c9)</span></li>
<li>src/appearencegtk.h <span style="color: grey">(f797a08)</span></li>
<li>src/appearencegtk.cpp <span style="color: grey">(9dee2d5)</span></li>
<li>src/cursorthemesmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/cursorthemesmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/gtkconfigkcmodule.h <span style="color: grey">(032a5ef)</span></li>
<li>src/gtkconfigkcmodule.cpp <span style="color: grey">(3d70f6e)</span></li>
<li>src/iconthemesmodel.cpp <span style="color: grey">(07c7ad7)</span></li>
<li>src/ui/gui.ui <span style="color: grey">(ebfacdf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126704/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>