Review Request 122403: [OS X] adaptations to phonon component.

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122403/#review94639
-----------------------------------------------------------



Anyone wanna shipit this? I can't really test, but the code looks fine in general.

- Harald Sitter


On Feb. 3, 2015, 12:41 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122403/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 12:41 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Runtime, Phonon, and Solid.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> I'm trying to make the kcm_phonon Multimedia control panel more useful on OS X, so that ideally users will be able to choose different devices for the different playback (or recording) categories.
> 
> This RR outlines the current state of my draft attempt to provide that support. I'm handicapped by my lack of experience with both IOKit and Solid, and would thus appreciate a helping hand.
> 
> I'm currently at a stage where Solid returns a list representing the audio devices present in my system, but apparently not with the correct metadata for phononserver to consider them:
> 
> ```
> kded(81671)/phonon (kded module) PhononServer::findDevices: Solid offers 5 audio devices
> kded(81671)/phonon (kded module) PhononServer::findDevices: Solid offers 0 video devices
> ...
> kded(81671)/phonon (kded module) PhononServer::findDevices: groups: ()
> kded(81671)/phonon (kded module) PhononServer::findDevices: already found devices: QSet()
> kded(81671)/phonon (kded module) PhononServer::findDevices: Audio Playback Devices: ()
> kded(81671)/phonon (kded module) PhononServer::findDevices: Audio Capture Devices: ()
> kded(81671)/phonon (kded module) PhononServer::findDevices: Video Capture Devices: ()
> kded(81671)/kded4 *Kded::loadModule: Successfully loaded module "phononserver"
> ```
> 
> Companion RR for the (required) changes to kdelibs:solid which is probably where most of the work will have to be done : https://git.reviewboard.kde.org/r/122404/ . That RR also has a full output log showing the available information about my devices.
> 
> 
> Diffs
> -----
> 
>   phonon/CMakeLists.txt b6ba4ec 
>   phonon/kcm/audiosetup.cpp 835799c 
>   phonon/kded-module/hardwaredatabase e353eea 
>   phonon/kded-module/phononserver.cpp 9a47423 
> 
> Diff: https://git.reviewboard.kde.org/r/122403/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5/MacPorts with kdelibs 4.14.4 (git/master), kde4-runtime (git/master) and kde4-workspace (git/master).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20160415/6223cd75/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel