<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122403/">https://git.reviewboard.kde.org/r/122403/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Anyone wanna shipit this? I can't really test, but the code looks fine in general.</p></pre>
<br />
<p>- Harald Sitter</p>
<br />
<p>On February 3rd, 2015, 12:41 p.m. UTC, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Runtime, Phonon, and Solid.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2015, 12:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm trying to make the kcm_phonon Multimedia control panel more useful on OS X, so that ideally users will be able to choose different devices for the different playback (or recording) categories.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This RR outlines the current state of my draft attempt to provide that support. I'm handicapped by my lack of experience with both IOKit and Solid, and would thus appreciate a helping hand.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm currently at a stage where Solid returns a list representing the audio devices present in my system, but apparently not with the correct metadata for phononserver to consider them:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">kded(81671)/phonon (kded module) PhononServer::findDevices: Solid offers 5 audio devices
kded(81671)/phonon (kded module) PhononServer::findDevices: Solid offers 0 video devices
...
kded(81671)/phonon (kded module) PhononServer::findDevices: groups: ()
kded(81671)/phonon (kded module) PhononServer::findDevices: already found devices: QSet()
kded(81671)/phonon (kded module) PhononServer::findDevices: Audio Playback Devices: ()
kded(81671)/phonon (kded module) PhononServer::findDevices: Audio Capture Devices: ()
kded(81671)/phonon (kded module) PhononServer::findDevices: Video Capture Devices: ()
kded(81671)/kded4 *Kded::loadModule: Successfully loaded module "phononserver"
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Companion RR for the (required) changes to kdelibs:solid which is probably where most of the work will have to be done : https://git.reviewboard.kde.org/r/122404/ . That RR also has a full output log showing the available information about my devices.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.9.5/MacPorts with kdelibs 4.14.4 (git/master), kde4-runtime (git/master) and kde4-workspace (git/master).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>phonon/CMakeLists.txt <span style="color: grey">(b6ba4ec)</span></li>
<li>phonon/kcm/audiosetup.cpp <span style="color: grey">(835799c)</span></li>
<li>phonon/kded-module/hardwaredatabase <span style="color: grey">(e353eea)</span></li>
<li>phonon/kded-module/phononserver.cpp <span style="color: grey">(9a47423)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122403/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>