Changes to our Git infrastructure
schumacher at kde.org
Wed Jan 7 10:43:20 GMT 2015
On Tuesday 06 January 2015 08:19:20 Thiago Macieira wrote:
> Unfortunately, as long as the tool permits line-by-line commenting, you're
> going to get nitpicking. My experience is that people are linear and will
> start reading the patch, calling out what they see when they see it.
I made some code experience with automatic checking of style issues and
similar things (e.g. with https://houndci.com). If a tool gives immediate
feedback about these things, reviewers don't have to do the nitpicking, and
there is no risk of reviewees taking it personal.
If the CI checks and comments the small issues, the review by the human
reviewer naturally focuses on more high-level questions.
Cornelius Schumacher <schumacher at kde.org>
More information about the kde-core-devel