Changes to our Git infrastructure

Boudewijn Rempt boud at
Tue Jan 6 16:39:18 GMT 2015

On Tue, 6 Jan 2015, Thiago Macieira wrote:

> Unfortunately, as long as the tool permits line-by-line commenting, you're
> going to get nitpicking. My experience is that people are linear and will
> start reading the patch, calling out what they see when they see it.
> They should instead look at the big picture first and that isn't easy.
> See

Lovely article. I know some people would object that the awful 
indentation makes the patch impossible to read, but apart from that 
specious argument, it's great advice.

I wonder if we can tweak a tool to only allow line-by-line comments after 
two high-level reviews have been written...


More information about the kde-core-devel mailing list