Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

[Frank Schütte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120839/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 1:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs, Solid, Christoph Feck, and Helio Castro.


Bugs: 243046 and 261376
    http://bugs.kde.org/show_bug.cgi?id=243046
    http://bugs.kde.org/show_bug.cgi?id=261376


Repository: kde-runtime


Description
-------

Hi Christoph,
solid-device-automounter fails to automount unknown devices, even if it is checked,
because in kded/DeviceAutomounter.cpp it fails to evaluate shouldAutomountDevice.
So this patch corrects the logic to at first evaluate shouldAutomountDevice.
Inside this evaluation automountUnknownDevices is evaluated correctly.
Please review this patch. Christoph Feck urged me to submit this patch.
It took me quite a while to figure it out, though.
Bye,
Frank


Diffs
-----

  solid-device-automounter/kded/DeviceAutomounter.cpp 14b4e87 
  solid-device-automounter/lib/AutomounterSettings.cpp 2b3e6be 

Diff: https://git.reviewboard.kde.org/r/120839/diff/


Testing
-------


Thanks,

Frank Schütte

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141029/2aa7e875/attachment.htm>