Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

[Christoph Feck]

> On Oct. 29, 2014, 12:02 p.m., Helio Castro wrote:
> > Ok, way better than the previous one :-)
> 
> Frank Schütte wrote:
>     Thanks for your approval. Now who is going to commit my patch? I don't have write access to the repository, as far as I know.
> 
> Christoph Feck wrote:
>     me. I am just not sure to which branch. When I commit to master, it will only available in 5.x releases.
>     
>     Does anyone think it should be in 4.14.3 release?
> 
> Thomas Lübking wrote:
>     I don't use automounting, but since enbaling automount of unknown devices currently breaks *all* automounting, I'd say this should be fixed in KDE 4 as well.
> 
> Frank Schütte wrote:
>     I would love to see this patch in KDE 4, because I rely on automounting in my local setup (I administer about 1000 computers in a school environment).

... wenn es doch für die Kinder ist, gerne ;)

I committed it to 4.14 branch. Thanks for the work, Frank, I 'urge' you to continue finding issues that help KDE in such large deployments.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120839/#review69425
-----------------------------------------------------------


On Oct. 29, 2014, 1:56 p.m., Frank Schütte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120839/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 1:56 p.m.)
> 
> 
> Review request for kdelibs, Solid, Christoph Feck, and Helio Castro.
> 
> 
> Bugs: 243046 and 261376
>     http://bugs.kde.org/show_bug.cgi?id=243046
>     http://bugs.kde.org/show_bug.cgi?id=261376
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> Hi Christoph,
> solid-device-automounter fails to automount unknown devices, even if it is checked,
> because in kded/DeviceAutomounter.cpp it fails to evaluate shouldAutomountDevice.
> So this patch corrects the logic to at first evaluate shouldAutomountDevice.
> Inside this evaluation automountUnknownDevices is evaluated correctly.
> Please review this patch. Christoph Feck urged me to submit this patch.
> It took me quite a while to figure it out, though.
> Bye,
> Frank
> 
> 
> Diffs
> -----
> 
>   solid-device-automounter/kded/DeviceAutomounter.cpp 14b4e87 
>   solid-device-automounter/lib/AutomounterSettings.cpp 2b3e6be 
> 
> Diff: https://git.reviewboard.kde.org/r/120839/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frank Schütte
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141029/4753a140/attachment.htm>