Review Request 121191: Use properly rounded brightness values in OSD

[Gabriele Mazzotta]

> On Nov. 20, 2014, 8:30 p.m., Kai Uwe Broulik wrote:
> > There does not seem to be a patch applied.

I'm sorry, I must have done something wrong.

Also, it took me some time to upload the diff because for some reason the link here in the webpage didn't work and it turned out there's an unescaped ' in my locale (Italian) that is breaking things.


- Gabriele


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121191/#review70709
-----------------------------------------------------------


On Nov. 20, 2014, 9 p.m., Gabriele Mazzotta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121191/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 9 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> If the max brightness is not a multiple of the step used to vary the brightness level, the OSD might not properly display the set value since it's not properly rounded. For instance, 89% might be displayed instead of 90% in the OSD when a 10% decrease in respect to the max brightness is done.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/bundled/brightnesscontrol.h 50e15d2 
>   powerdevil/daemon/actions/bundled/brightnesscontrol.cpp 59bbbcc 
> 
> Diff: https://git.reviewboard.kde.org/r/121191/diff/
> 
> 
> Testing
> -------
> 
> I actually tested this on v4.11.13, so I apologize in advance in case something is wrong.
> 
> 
> Thanks,
> 
> Gabriele Mazzotta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141120/80345519/attachment.htm>