Review Request 121191: Use properly rounded brightness values in OSD

Gabriele Mazzotta gabriele.mzt at
Thu Nov 20 21:00:05 GMT 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 20, 2014, 9 p.m.)

Review request for kde-workspace.

Repository: kde-workspace


If the max brightness is not a multiple of the step used to vary the brightness level, the OSD might not properly display the set value since it's not properly rounded. For instance, 89% might be displayed instead of 90% in the OSD when a 10% decrease in respect to the max brightness is done.

Diffs (updated)

  powerdevil/daemon/actions/bundled/brightnesscontrol.h 50e15d2 
  powerdevil/daemon/actions/bundled/brightnesscontrol.cpp 59bbbcc 



I actually tested this on v4.11.13, so I apologize in advance in case something is wrong.


Gabriele Mazzotta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list