Review Request 121191: Use properly rounded brightness values in OSD

Kai Uwe Broulik kde at privat.broulik.de
Thu Nov 20 20:30:04 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121191/#review70709
-----------------------------------------------------------


There does not seem to be a patch applied.

- Kai Uwe Broulik


On Nov. 20, 2014, 8:18 nachm., Gabriele Mazzotta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121191/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 8:18 nachm.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> If the max brightness is not a multiple of the step used to vary the brightness level, the OSD might not properly display the set value since it's not properly rounded. For instance, 89% might be displayed instead of 90% in the OSD when a 10% decrease in respect to the max brightness is done.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/121191/diff/
> 
> 
> Testing
> -------
> 
> I actually tested this on v4.11.13, so I apologize in advance in case something is wrong.
> 
> 
> Thanks,
> 
> Gabriele Mazzotta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141120/18685457/attachment.htm>


More information about the kde-core-devel mailing list