Review Request 121191: Use properly rounded brightness values in OSD

Gabriele Mazzotta gabriele.mzt at gmail.com
Thu Nov 20 20:18:38 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121191/
-----------------------------------------------------------

Review request for kde-workspace.


Summary (updated)
-----------------

Use properly rounded brightness values in OSD


Repository: kde-workspace


Description (updated)
-------

If the max brightness is not a multiple of the step used to vary the brightness level, the OSD might not properly display the set value since it's not properly rounded. For instance, 89% might be displayed instead of 90% in the OSD when a 10% decrease in respect to the max brightness is done.


Diffs
-----


Diff: https://git.reviewboard.kde.org/r/121191/diff/


Testing (updated)
-------

I actually tested this on v4.11.13, so I apologize in advance in case something is wrong.


Thanks,

Gabriele Mazzotta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141120/e91655c9/attachment.htm>


More information about the kde-core-devel mailing list