Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler

Wolfgang Bauer wbauer at tmo.at
Thu Jun 5 14:16:51 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118563/
-----------------------------------------------------------

Review request for kde-workspace.


Repository: kde-workspace


Description
-------

As discussed in https://git.reviewboard.kde.org/r/117091/. Not using the SA_RESTART flag might (in theory) cause the greeter to be aborted (because certain syscalls may be interrupted and fail with EINTR).
SA_RESTART seems to be the BSD default and is used by "legacy" signal() by default in glibc 2 and later as well, anyway.


Diffs
-----

  ksmserver/screenlocker/greeter/main.cpp 4cac94c 

Diff: https://git.reviewboard.kde.org/r/118563/diff/


Testing
-------

I'm using this myself for one month without any problems.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140605/16967044/attachment.htm>


More information about the kde-core-devel mailing list