Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118563/#review59329
-----------------------------------------------------------

Ship it!


the master (plasma-workspace repo) has a unit test for the signals. But I'm not sure whether we can extend it to catch this condition (we don't have a BSD CI system yet).

- Martin Gräßlin


On June 5, 2014, 3:16 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118563/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 3:16 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> As discussed in https://git.reviewboard.kde.org/r/117091/. Not using the SA_RESTART flag might (in theory) cause the greeter to be aborted (because certain syscalls may be interrupted and fail with EINTR).
> SA_RESTART seems to be the BSD default and is used by "legacy" signal() by default in glibc 2 and later as well, anyway.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/main.cpp 4cac94c 
> 
> Diff: https://git.reviewboard.kde.org/r/118563/diff/
> 
> 
> Testing
> -------
> 
> I'm using this myself for one month without any problems.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140605/bc936b27/attachment.htm>