Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

[Arjun Ak]

> On July 20, 2014, 2:51 p.m., Thomas Lübking wrote:
> > lib/konq/konq_operations.cpp, line 473
> > <https://git.reviewboard.kde.org/r/119372/diff/2/?file=291313#file291313line473>
> >
> >     this belongs into the ::supportsDeleting() branch

ok


> On July 20, 2014, 2:51 p.m., Thomas Lübking wrote:
> > lib/konq/konq_operations.cpp, line 478
> > <https://git.reviewboard.kde.org/r/119372/diff/2/?file=291313#file291313line478>
> >
> >     can be assigned directly to QFileInfo((*it).directory()).isWritable()

Does it make a difference?


> On July 20, 2014, 2:51 p.m., Thomas Lübking wrote:
> > lib/konq/konq_operations.cpp, line 479
> > <https://git.reviewboard.kde.org/r/119372/diff/2/?file=291313#file291313line479>
> >
> >     is there any guarantee that all urls in lst are in the same directory?

what?


> On July 20, 2014, 2:51 p.m., Thomas Lübking wrote:
> > lib/konq/konq_operations.cpp, line 482
> > <https://git.reviewboard.kde.org/r/119372/diff/2/?file=291313#file291313line482>
> >
> >     this must not override the value (what is atm. only protected by the break steatement; which is at least a behavioral change and assumingly wrong)

why?


- Arjun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119372/#review62729
-----------------------------------------------------------


On July 20, 2014, 1:30 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119372/
> -----------------------------------------------------------
> 
> (Updated July 20, 2014, 1:30 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Bugs: 337486
>     http://bugs.kde.org/show_bug.cgi?id=337486
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fixes Bug 337486
> 
> 
> Diffs
> -----
> 
>   lib/konq/konq_operations.cpp 220a90a 
> 
> Diff: https://git.reviewboard.kde.org/r/119372/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140721/68930bd0/attachment.htm>