Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

Thomas Lübking thomas.luebking at gmail.com
Sun Jul 20 10:21:04 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119372/#review62729
-----------------------------------------------------------



lib/konq/konq_operations.cpp
<https://git.reviewboard.kde.org/r/119372/#comment43477>

    this belongs into the ::supportsDeleting() branch



lib/konq/konq_operations.cpp
<https://git.reviewboard.kde.org/r/119372/#comment43479>

    can be assigned directly to QFileInfo((*it).directory()).isWritable()



lib/konq/konq_operations.cpp
<https://git.reviewboard.kde.org/r/119372/#comment43478>

    is there any guarantee that all urls in lst are in the same directory?



lib/konq/konq_operations.cpp
<https://git.reviewboard.kde.org/r/119372/#comment43480>

    this must not override the value (what is atm. only protected by the break steatement; which is at least a behavioral change and assumingly wrong)


- Thomas Lübking


On Juli 20, 2014, 8 vorm., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119372/
> -----------------------------------------------------------
> 
> (Updated Juli 20, 2014, 8 vorm.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Bugs: 337486
>     http://bugs.kde.org/show_bug.cgi?id=337486
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fixes Bug 337486
> 
> 
> Diffs
> -----
> 
>   lib/konq/konq_operations.cpp 220a90a 
> 
> Diff: https://git.reviewboard.kde.org/r/119372/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140720/787170ef/attachment.htm>


More information about the kde-core-devel mailing list