Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

[Thomas Lübking]

> On Juli 20, 2014, 9:21 vorm., Thomas Lübking wrote:
> > lib/konq/konq_operations.cpp, line 479
> > <https://git.reviewboard.kde.org/r/119372/diff/2/?file=291313#file291313line479>
> >
> >     is there any guarantee that all urls in lst are in the same directory?
> 
> Arjun Ak wrote:
>     what?

you're shortcutting the for loop if _any_ iterated element is in a read only directory.
Unless there's some outer guarantee that _all_ elements are in the same directory, you're omitting elements randomly depending on their position in the list (ie. once a file is not movable for that reason)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119372/#review62729
-----------------------------------------------------------


On Juli 20, 2014, 8 vorm., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119372/
> -----------------------------------------------------------
> 
> (Updated Juli 20, 2014, 8 vorm.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Bugs: 337486
>     http://bugs.kde.org/show_bug.cgi?id=337486
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fixes Bug 337486
> 
> 
> Diffs
> -----
> 
>   lib/konq/konq_operations.cpp 220a90a 
> 
> Diff: https://git.reviewboard.kde.org/r/119372/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140721/e76d05fb/attachment.htm>