Review Request 113366: kio_http: small optimization in response code parsing
Commit Hook
null at kde.org
Tue Oct 22 21:06:12 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113366/#review42185
-----------------------------------------------------------
This review has been submitted with commit 75a4d5deaa9e0d263d37514292cab36e9e895c2e by Andrea Iacovitti to branch KDE/4.11.
- Commit Hook
On Oct. 21, 2013, 3:23 p.m., Andrea Iacovitti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113366/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 3:23 p.m.)
>
>
> Review request for kdelibs and Dawit Alemayehu.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Execute the long "if...else if..." only if the previous condition "if (m_request.responseCode != 200 && m_request.responseCode != 304)" is verified.
> If it fails (that is responseCode == 200 or responseCode == 304) none of the nine conditions in the subsequent if..else if.. can be true.
>
>
> Diffs
> -----
>
> kioslave/http/http.cpp 81182eb
>
> Diff: http://git.reviewboard.kde.org/r/113366/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrea Iacovitti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131022/300d108c/attachment.htm>
More information about the kde-core-devel
mailing list