Review Request 113366: kio_http: small optimization in response code parsing

Dawit Alemayehu adawit at kde.org
Tue Oct 22 06:03:42 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113366/#review42146
-----------------------------------------------------------

Ship it!


Ship It!

- Dawit Alemayehu


On Oct. 21, 2013, 3:23 p.m., Andrea Iacovitti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113366/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 3:23 p.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Execute the long "if...else if..." only if the previous condition "if (m_request.responseCode != 200 && m_request.responseCode != 304)" is verified.
> If it fails (that is responseCode == 200 or responseCode == 304) none of the nine conditions in the subsequent if..else if.. can be true.
> 
> 
> Diffs
> -----
> 
>   kioslave/http/http.cpp 81182eb 
> 
> Diff: http://git.reviewboard.kde.org/r/113366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131022/f323d3fa/attachment.htm>


More information about the kde-core-devel mailing list