Review Request 113366: kio_http: small optimization in response code parsing

Andrea Iacovitti aiacovitti at libero.it
Tue Oct 22 21:06:20 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113366/
-----------------------------------------------------------

(Updated Oct. 22, 2013, 8:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and Dawit Alemayehu.


Repository: kdelibs


Description
-------

Execute the long "if...else if..." only if the previous condition "if (m_request.responseCode != 200 && m_request.responseCode != 304)" is verified.
If it fails (that is responseCode == 200 or responseCode == 304) none of the nine conditions in the subsequent if..else if.. can be true.


Diffs
-----

  kioslave/http/http.cpp 81182eb 

Diff: http://git.reviewboard.kde.org/r/113366/diff/


Testing
-------


Thanks,

Andrea Iacovitti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131022/bf07d04b/attachment.htm>


More information about the kde-core-devel mailing list