Review Request 113846: fix kicontheme::list

Christoph Feck christoph at maxiom.de
Wed Nov 13 21:32:50 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113846/#review43637
-----------------------------------------------------------



tier3/kiconthemes/src/kicontheme.cpp
<http://git.reviewboard.kde.org/r/113846/#comment31365>

    Use '/' (single quotes) for single characters.
    
    But this line also misses some QLatin1String or QStringLiteral to be NO_ASCII_CAST safe.
    


- Christoph Feck


On Nov. 13, 2013, 5:33 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113846/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 5:33 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> kicontheme does not find any icon themes because it misses the trailing slash on the directory name
> 
> 
> Diffs
> -----
> 
>   tier3/kiconthemes/src/kicontheme.cpp 33261fe 
> 
> Diff: http://git.reviewboard.kde.org/r/113846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131113/d96fba42/attachment.htm>


More information about the kde-core-devel mailing list