Review Request 113846: fix kicontheme::list
Albert Astals Cid
aacid at kde.org
Wed Nov 13 19:24:03 GMT 2013
> On Nov. 13, 2013, 7:11 p.m., Aleix Pol Gonzalez wrote:
> > Ship it, as long as tests still pass. :)
And maybe even add a test that fails without this patch so it doesn't break again?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113846/#review43623
-----------------------------------------------------------
On Nov. 13, 2013, 5:33 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113846/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 5:33 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> kicontheme does not find any icon themes because it misses the trailing slash on the directory name
>
>
> Diffs
> -----
>
> tier3/kiconthemes/src/kicontheme.cpp 33261fe
>
> Diff: http://git.reviewboard.kde.org/r/113846/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131113/e1bd8d5c/attachment.htm>
More information about the kde-core-devel
mailing list