<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113846/">http://git.reviewboard.kde.org/r/113846/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113846/diff/1/?file=213977#file213977line521" style="color: black; font-weight: bold; text-decoration: underline;">tier3/kiconthemes/src/kicontheme.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QStringList KIconTheme::list()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">521</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">QFile</span><span class="o">::</span><span class="n">exists</span><span class="p">(</span><span class="n">it</span> <span class="o">+</span> <span class="o">*</span><span class="n">it2</span> <span class="o">+</span> <span class="s">"/index.desktop"</span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">QFile</span><span class="o">::</span><span class="n">exists</span><span class="p">(</span><span class="n">it</span> <span class="o">+</span> <span class="o">*</span><span class="n">it2</span> <span class="o">+</span> <span class="s">&q
uot;/index.theme"</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">521</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">QFile</span><span class="o">::</span><span class="n">exists</span><span class="p">(</span><span class="n">it</span><span class="hl"> </span><span class="o"><span class="hl">+</span></span><span class="hl"> </span><span class="s"><span class="hl">"/"</span></span> <span class="o">+</span> <span class="o">*</span><span class="n">it2</span> <span class="o">+</span> <span class="s">"/index.desktop"</span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">QFile</span><span class="o">::</span><span class="n">exists</span><span class
="p">(</span><span class="n">it</span> <span class="o">+</span> <span class="s"><span class="hl">"/"</span></span><span class="hl"> </span><span class="o"><span class="hl">+</span>
</span><span class="hl"> </span><span class="o">*</span><span class="n">it2</span> <span class="o">+</span> <span class="s">"/index.theme"</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use '/' (single quotes) for single characters.
But this line also misses some QLatin1String or QStringLiteral to be NO_ASCII_CAST safe.
</pre>
</div>
<br />
<p>- Christoph Feck</p>
<br />
<p>On November 13th, 2013, 5:33 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2013, 5:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kicontheme does not find any icon themes because it misses the trailing slash on the directory name
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/kiconthemes/src/kicontheme.cpp <span style="color: grey">(33261fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113846/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>