Review Request 111164: Create FavIconsModule namespace in kdebug
David Faure
faure at kde.org
Fri Jun 21 21:29:53 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111164/#review34837
-----------------------------------------------------------
Ship it!
It's all commented out, but if that makes you happy, go for it :)
(yes, make the function file-static first)
- David Faure
On June 21, 2013, 6:55 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111164/
> -----------------------------------------------------------
>
> (Updated June 21, 2013, 6:55 p.m.)
>
>
> Review request for KDE Base Apps and David Faure.
>
>
> Description
> -------
>
> Make FaviIconsModule a better neighbor of the KDED community by having its own namespace :p
>
>
> Diffs
> -----
>
> lib/konq/favicons/favicons.cpp 45d6c19
>
> Diff: http://git.reviewboard.kde.org/r/111164/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130621/f187517b/attachment.htm>
More information about the kde-core-devel
mailing list