Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

Àlex Fiestas afiestas at kde.org
Sat Jun 22 11:25:14 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111171/
-----------------------------------------------------------

Review request for KDE Frameworks and kdelibs.


Description
-------

Deprecate: inactiveTitleColor, inactiveTextColor, activeTitleColor, activeTextColor in favor of KColorScheme and replace the implementation of those methods with it.


Diffs
-----

  kdeui/util/kglobalsettings.h 4b77ed5 
  kdeui/util/kglobalsettings.cpp 3e60632 
  khtml/misc/helper.cpp dccb9bf 

Diff: http://git.reviewboard.kde.org/r/111171/diff/


Testing
-------

I have compared the colors returned by the methods before and after this patch, they are close enough.

Additionally used some apps like filelight with the change, and it seems to work for them as well.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130622/de37ed47/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


More information about the kde-core-devel mailing list