Review Request 111164: Create FavIconsModule namespace in kdebug

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111164/#review34836
-----------------------------------------------------------



lib/konq/favicons/favicons.cpp
<http://git.reviewboard.kde.org/r/111164/#comment25528>

    Since dfavi() is local to this file, it should be static I think.
    
    nitpick: It would be more coding-style compliant to write the function body like a normal function instead of putting everything on the same line.


- Aurélien Gâteau


On June 21, 2013, 8:55 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111164/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 8:55 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> Make FaviIconsModule a better neighbor of the KDED community by having its own namespace :p
> 
> 
> Diffs
> -----
> 
>   lib/konq/favicons/favicons.cpp 45d6c19 
> 
> Diff: http://git.reviewboard.kde.org/r/111164/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130621/195f0b5d/attachment.htm>