Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

[Sandro Andrade]

> On Jan. 31, 2013, 10:16 a.m., Chao Feng wrote:
> > File Attachment: Bulk operations (2nd layout) - 2
> > <http://git.reviewboard.kde.org/r/108570/#fcomment32>
> >
> >     I think lots of people will be confused by this check list. Why I need to select it? The action button is too far away. 
> >     
> >     Even the normal web way of "Select many items and do an action" is considered a bad pratice. 
> >     
> >     It is the limitation of old web form. Now more and more sites fix it by using ajax action. 
> >     
> >     This change did not save many clicks. Can we find a simple way to do it instead of make it confusing?

Hi Chao, thanks for reviewing

As stated in the initial patch description, suggestions about UI usability/layout are pretty welcome since I've asked myself a couple times what would be the best way to implement that. It seems we have two different questions to address:

1) Do we really need this functionality ?

I'm not sure how many KDE users usually set all their systray icons as 'Always Visible' (or some other value). I've find myself doing that a couple of times and it requires (2*i+1) mouse clicks (i = #items in systray). This patch reduces that to 4 mouse clicks. But if you guys find it uninteresting or even consider systray configuration an scarce event (made once per desktop configuration) I'm totally fine to drop it :)

2) If we do need it, how to properly have it done ?

I've proposed two alternatives. Maybe creating a new QTreeWidgetItem for bulk operations (at same item's table) might also works.

Thanks,


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108570/#review26453
-----------------------------------------------------------


On Jan. 30, 2013, 10:50 a.m., Sandro Andrade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108570/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2013, 10:50 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> In page 'entries', user can select/deselect a specific or all entries and then change visibility and/or reset shortcut for all of them with a single combo selection/clear button click. Individually selecting all entries causes header's checkbox to automatically be checked. After selecting all entries (individually or by clicking in header's checkbox), a single entry deselection causes header's checkbox to automatically be unchecked. General suggestions and, in particular about UI usability, are appreciated.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/systemtray/ui/applet.h 0b4a869 
>   plasma/generic/applets/systemtray/ui/applet.cpp 09482d7 
>   plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff 
> 
> Diff: http://git.reviewboard.kde.org/r/108570/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Initial setup
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png
> Setting all visibilities to 'Auto'
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png
> All visibilities adjusted to 'Auto'
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png
> Setting two specific item visibilities to 'Always Visible'
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png
> Bulk operations (2nd layout) - 1
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/30/systray-bulk-tableless1.png
> Bulk operations (2nd layout) - 2
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/30/systray-bulk-tableless2.png
> 
> 
> Thanks,
> 
> Sandro Andrade
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130131/93a3bcbe/attachment.htm>