<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108570/">http://git.reviewboard.kde.org/r/108570/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 31st, 2013, 10:16 a.m. BRT, <b>Chao Feng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/30/systray-bulk-tableless2.png" style="color: black; font-weight: bold; font-size: 9pt;">Bulk operations (2nd layout) - 2</a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think lots of people will be confused by this check list. Why I need to select it? The action button is too far away.
Even the normal web way of "Select many items and do an action" is considered a bad pratice.
It is the limitation of old web form. Now more and more sites fix it by using ajax action.
This change did not save many clicks. Can we find a simple way to do it instead of make it confusing? </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Chao, thanks for reviewing
As stated in the initial patch description, suggestions about UI usability/layout are pretty welcome since I've asked myself a couple times what would be the best way to implement that. It seems we have two different questions to address:
1) Do we really need this functionality ?
I'm not sure how many KDE users usually set all their systray icons as 'Always Visible' (or some other value). I've find myself doing that a couple of times and it requires (2*i+1) mouse clicks (i = #items in systray). This patch reduces that to 4 mouse clicks. But if you guys find it uninteresting or even consider systray configuration an scarce event (made once per desktop configuration) I'm totally fine to drop it :)
2) If we do need it, how to properly have it done ?
I've proposed two alternatives. Maybe creating a new QTreeWidgetItem for bulk operations (at same item's table) might also works.
Thanks,</pre>
<br />
<p>- Sandro</p>
<br />
<p>On January 30th, 2013, 10:50 a.m. BRT, Sandro Andrade wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Sandro Andrade.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2013, 10:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In page 'entries', user can select/deselect a specific or all entries and then change visibility and/or reset shortcut for all of them with a single combo selection/clear button click. Individually selecting all entries causes header's checkbox to automatically be checked. After selecting all entries (individually or by clicking in header's checkbox), a single entry deselection causes header's checkbox to automatically be unchecked. General suggestions and, in particular about UI usability, are appreciated.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/ui/applet.h <span style="color: grey">(0b4a869)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.cpp <span style="color: grey">(09482d7)</span></li>
<li>plasma/generic/applets/systemtray/ui/autohide.ui <span style="color: grey">(3b6efff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108570/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png">Initial setup</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png">Setting all visibilities to 'Auto'</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png">All visibilities adjusted to 'Auto'</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png">Setting two specific item visibilities to 'Always Visible'</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/30/systray-bulk-tableless1.png">Bulk operations (2nd layout) - 1</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/30/systray-bulk-tableless2.png">Bulk operations (2nd layout) - 2</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>