Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

Chao Feng rainofchaos at gmail.com
Thu Jan 31 13:16:26 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108570/#review26453
-----------------------------------------------------------



File Attachment: Bulk operations (2nd layout) - 2
<http://git.reviewboard.kde.org//r/108570/#fcomment31>
    I think lots of people will be confused by this check list. Why I need to select it? The action button is too far away. 
    
    Even the normal web way of "Select many items and do an action" is considered a bad pratice. 
    
    It is the limitation of old web form. Now more and more sites fix it by using ajax action. 
    
    This change did not save many clicks. Can we find a simple way to do it instead of make it confusing? 

- Chao Feng


On Jan. 30, 2013, 1:50 p.m., Sandro Andrade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108570/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2013, 1:50 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> In page 'entries', user can select/deselect a specific or all entries and then change visibility and/or reset shortcut for all of them with a single combo selection/clear button click. Individually selecting all entries causes header's checkbox to automatically be checked. After selecting all entries (individually or by clicking in header's checkbox), a single entry deselection causes header's checkbox to automatically be unchecked. General suggestions and, in particular about UI usability, are appreciated.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/systemtray/ui/applet.h 0b4a869 
>   plasma/generic/applets/systemtray/ui/applet.cpp 09482d7 
>   plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff 
> 
> Diff: http://git.reviewboard.kde.org/r/108570/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Initial setup
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png
> Setting all visibilities to 'Auto'
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png
> All visibilities adjusted to 'Auto'
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png
> Setting two specific item visibilities to 'Always Visible'
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png
> Bulk operations (2nd layout) - 1
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/30/systray-bulk-tableless1.png
> Bulk operations (2nd layout) - 2
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/30/systray-bulk-tableless2.png
> 
> 
> Thanks,
> 
> Sandro Andrade
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130131/2c8be572/attachment.htm>


More information about the kde-core-devel mailing list