Review Request: fix 234407 - set minimum width for system settings icon view

[Xuetian Weng]

> On Jan. 10, 2013, 6:12 p.m., Thomas Lübking wrote:
> > systemsettings/icons/IconMode.cpp, line 182
> > <http://git.reviewboard.kde.org/r/108328/diff/1/?file=106487#file106487line182>
> >
> >     should this not rely on the icon size rather than on the fontmetrics (only)?
> >     The point is to get more size between the icons, i thought ;-)

no, it's to have more space for the string, and to make it "less wrapped", Current code doesn't work well since it seems trying to "shrink the string" as much as possible, and CJK character doesn't break in to "non-wrappable" string like English so it doesn't work well. It doesn't matter how big is your icon.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108328/#review25177
-----------------------------------------------------------


On Jan. 10, 2013, 8:47 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108328/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 8:47 p.m.)
> 
> 
> Review request for kde-workspace, Ben Cooksley, Thomas Lübking, Chao Feng, and Yichao Yu.
> 
> 
> Description
> -------
> 
> Set minimum width for system settings icon view item depending on font. Since KFileItemDelegate doesn't provides setMinimumSize, we make a sub-class that can have a minimumSize. (Maybe should be add to kdelibs in the future?)
> 
> This fontHeight * 6 heuristic value works for all languages. CJK character is usually square (width = height) so this roughly means 6 CJK character, and 12 latin letter (height = width * 2), which will always look good.
> 
> To fengchao, I'm sorry if you feel I steal your job.. but I can't stop myself since I think I can fix it in 10 minutes..
> 
> 
> This addresses bug 234407.
>     http://bugs.kde.org/show_bug.cgi?id=234407
> 
> 
> Diffs
> -----
> 
>   systemsettings/icons/CMakeLists.txt 0830dd7 
>   systemsettings/icons/FileItemDelegate.h PRE-CREATION 
>   systemsettings/icons/FileItemDelegate.cpp PRE-CREATION 
>   systemsettings/icons/IconMode.cpp 37cfc4b 
> 
> Diff: http://git.reviewboard.kde.org/r/108328/diff/
> 
> 
> Testing
> -------
> 
> see screenshot.
> 
> 
> Screenshots
> -----------
> 
> english after change
>   http://git.reviewboard.kde.org/r/108328/s/1014/
> chinese after change
>   http://git.reviewboard.kde.org/r/108328/s/1015/
> chinese before change
>   http://git.reviewboard.kde.org/r/108328/s/1016/
> spanish after change
>   http://git.reviewboard.kde.org/r/108328/s/1017/
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130110/a405dc55/attachment.htm>