<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108328/">http://git.reviewboard.kde.org/r/108328/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 10th, 2013, 6:12 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108328/diff/1/?file=106487#file106487line182" style="color: black; font-weight: bold; text-decoration: underline;">systemsettings/icons/IconMode.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void IconMode::initWidget()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">182</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">delegate</span><span class="o">-></span><span class="n">setMinimumSize</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span class="n">QApplication</span><span class="o">::</span><span class="n">fontMetrics</span><span class="p">().</span><span class="n">height</span><span class="p">()</span> <span class="o">*</span> <span class="mi">6</span><span class="p">,</span> <span class="mi">1</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should this not rely on the icon size rather than on the fontmetrics (only)?
The point is to get more size between the icons, i thought ;-)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no, it's to have more space for the string, and to make it "less wrapped", Current code doesn't work well since it seems trying to "shrink the string" as much as possible, and CJK character doesn't break in to "non-wrappable" string like English so it doesn't work well. It doesn't matter how big is your icon.</pre>
<br />
<p>- Xuetian</p>
<br />
<p>On January 10th, 2013, 8:47 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace, Ben Cooksley, Thomas Lübking, Chao Feng, and Yichao Yu.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2013, 8:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set minimum width for system settings icon view item depending on font. Since KFileItemDelegate doesn't provides setMinimumSize, we make a sub-class that can have a minimumSize. (Maybe should be add to kdelibs in the future?)
This fontHeight * 6 heuristic value works for all languages. CJK character is usually square (width = height) so this roughly means 6 CJK character, and 12 latin letter (height = width * 2), which will always look good.
To fengchao, I'm sorry if you feel I steal your job.. but I can't stop myself since I think I can fix it in 10 minutes..</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see screenshot.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=234407">234407</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>systemsettings/icons/CMakeLists.txt <span style="color: grey">(0830dd7)</span></li>
<li>systemsettings/icons/FileItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>systemsettings/icons/FileItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>systemsettings/icons/IconMode.cpp <span style="color: grey">(37cfc4b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108328/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108328/s/1014/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings1_400x100.png" style="border: 1px black solid;" alt="english after change" /></a>
<a href="http://git.reviewboard.kde.org/r/108328/s/1015/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings2_400x100.png" style="border: 1px black solid;" alt="chinese after change" /></a>
<a href="http://git.reviewboard.kde.org/r/108328/s/1016/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings3_400x100.png" style="border: 1px black solid;" alt="chinese before change" /></a>
<a href="http://git.reviewboard.kde.org/r/108328/s/1017/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings4_400x100.png" style="border: 1px black solid;" alt="spanish after change" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>