Review Request: fix isMinimized in KWindowInfo

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108314/#review25109
-----------------------------------------------------------


There should be no problem with ths one since WMs are encouraged ("should", *sigh*) to set _NET_WM_HIDDEN for minimized windows and the major ones do.
If _NET_WM_STATE is absent it's considered 0, thus does not match HIDDEN, thus passes the check over to the ICCCM state.

The "weird" condition is when a window has HIDDEN but not inconified, just that this is what the patch uses a fix.
No apparent concerns from my side.

- Thomas Lübking


On Jan. 9, 2013, 11:25 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108314/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 11:25 p.m.)
> 
> 
> Review request for kdelibs, Thomas Lübking and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Check NETWM 1.2 condition first. One case when old code doesn't work: kwin enable always keep thumbnails, kwin still use NET:Hidden in the minimized window, but mappingState is not Iconic.
> 
> This would fix if kwin enable always keep thumbnails for all window, pager still show window is not minimized.
> 
> 
> Diffs
> -----
> 
>   kdeui/windowmanagement/kwindowinfo_x11.cpp d983c9a 
> 
> Diff: http://git.reviewboard.kde.org/r/108314/diff/
> 
> 
> Testing
> -------
> 
> compiles and pager is fixed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130110/40b4064a/attachment.htm>