<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108314/">http://git.reviewboard.kde.org/r/108314/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There should be no problem with ths one since WMs are encouraged ("should", *sigh*) to set _NET_WM_HIDDEN for minimized windows and the major ones do.
If _NET_WM_STATE is absent it's considered 0, thus does not match HIDDEN, thus passes the check over to the ICCCM state.
The "weird" condition is when a window has HIDDEN but not inconified, just that this is what the patch uses a fix.
No apparent concerns from my side.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On January 9th, 2013, 11:25 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Thomas Lübking and Martin Gräßlin.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2013, 11:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Check NETWM 1.2 condition first. One case when old code doesn't work: kwin enable always keep thumbnails, kwin still use NET:Hidden in the minimized window, but mappingState is not Iconic.
This would fix if kwin enable always keep thumbnails for all window, pager still show window is not minimized.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and pager is fixed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/windowmanagement/kwindowinfo_x11.cpp <span style="color: grey">(d983c9a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108314/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>